Skip to content

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 6, 2025

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

the push silently fails https://github.com/algolia/api-clients-automation/actions/runs/15463968082/job/43532734476 with fatal: could not read Username for 'https://github.com/': No such device or address

works properly now https://github.com/algolia/api-clients-automation/actions/runs/15486841829/job/43603897640?pr=4941#step:12:1

@shortcuts shortcuts self-assigned this Jun 6, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 6, 2025

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1710
javascript 1642
php 1512
csharp 1377
java 1075
python 1072
ruby 796
swift 458
scala 23

@shortcuts shortcuts marked this pull request as ready for review June 6, 2025 09:13
@shortcuts shortcuts requested a review from a team as a code owner June 6, 2025 09:13
@shortcuts shortcuts requested review from millotp and morganleroi June 6, 2025 09:13
}

export function ensureGitHubToken(): string {
const githubToken = process.env.GITHUB_TOKEN || process.env.GH_TOKEN || '';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you check that they are both present ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one or the other is fine, gh supports any of the two

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it needed to provide both in the CI then ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc is a bit vague, https://cli.github.com/manual/gh_auth_login#:~:text=To%20use%20gh%20in%20GitHub%20Actions%2C%20add%20GH_TOKEN%3A%20%24%7B%7B%20github.token%20%7D%7D%20to%20env. states that it reads GH_TOKEN on the CI, however we might use GITHUB_TOKEN locally, costs nothing to have both

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so it expects GITHUB_TOKEN locally but GH_TOKEN on the CI, this is super weird

@shortcuts shortcuts enabled auto-merge (squash) June 6, 2025 10:14
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@shortcuts shortcuts merged commit 8db88fd into main Jun 6, 2025
27 checks passed
@shortcuts shortcuts deleted the fix/pushToRepository branch June 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants