-
Notifications
You must be signed in to change notification settings - Fork 26
fix(scripts): push to repository #4941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. 📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
} | ||
|
||
export function ensureGitHubToken(): string { | ||
const githubToken = process.env.GITHUB_TOKEN || process.env.GH_TOKEN || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you check that they are both present ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one or the other is fine, gh supports any of the two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it needed to provide both in the CI then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the doc is a bit vague, https://cli.github.com/manual/gh_auth_login#:~:text=To%20use%20gh%20in%20GitHub%20Actions%2C%20add%20GH_TOKEN%3A%20%24%7B%7B%20github.token%20%7D%7D%20to%20env. states that it reads GH_TOKEN on the CI, however we might use GITHUB_TOKEN locally, costs nothing to have both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so it expects GITHUB_TOKEN
locally but GH_TOKEN
on the CI, this is super weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg !
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
the push silently fails https://github.com/algolia/api-clients-automation/actions/runs/15463968082/job/43532734476 with
fatal: could not read Username for 'https://github.com/': No such device or address
works properly now https://github.com/algolia/api-clients-automation/actions/runs/15486841829/job/43603897640?pr=4941#step:12:1